From 737ee9306d0a678eceae6e9d108d4f5d3734df3f Mon Sep 17 00:00:00 2001 From: Anders Roxell Date: Thu, 1 Aug 2019 15:56:17 +0200 Subject: [PATCH] mm: memcg: fix parentheses warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GCC warns and suggests parentheses around assignment. ../mm/memcontrol.c: In function ‘invalidate_reclaim_iterators’: ../mm/memcontrol.c:1160:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] } while (memcg = parent_mem_cgroup(memcg)); ^~~~~ Rework to add parentheses around assingment. Fixes: c48a2f5ce935 ("mm/memcontrol.c: fix use after free in mem_cgroup_iter()") Signed-off-by: Anders Roxell --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 694b6f8776dc..4f66a8305ae0 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1157,7 +1157,7 @@ static void invalidate_reclaim_iterators(struct mem_cgroup *dead_memcg) do { __invalidate_reclaim_iterators(memcg, dead_memcg); last = memcg; - } while (memcg = parent_mem_cgroup(memcg)); + } while ((memcg = parent_mem_cgroup(memcg))); /* * When cgruop1 non-hierarchy mode is used, -- 2.20.1